ref: Update sentry-cli and refresh GH actions#368
Conversation
kamilogorek
force-pushed
the
update-cli
branch
2 times, most recently
from
0f7395c to
70bf094
Compare
kamilogorek
changed the title
| }, | ||
| "dependencies": { | ||
| "@sentry/cli": "^2.0.2" | ||
| "@sentry/cli": "^1.74.4" |
There was a problem hiding this comment.
This PR is downgrading @sentry/cli from v2 to v1. Is this intentional?
The release notes say that the major version was upgraded, but the reality is that in 1.18.9 release we are still stuck with @sentry/cli v1 😕
cc @sawilde
There was a problem hiding this comment.
Thanks for pointing that out, changelog is incorrect; updated it.
We stick to v1 for now, as v2 has minimal version of node set to 12, which is not the case for this plugin.
We'll update major once we decide to move the plugin to the next major as well.
There was a problem hiding this comment.
nw - thanks for the update
would the alternative be - as horrid it may sound - to have two branches one supporting v1 and the other v2 of @sentry/cli? I've seen other packages do something similar but not sure on how maintainable it would be for the team.
There was a problem hiding this comment.
We are definitely going to have v1 and v2, however, it still requires doing some work and major release, which I don't have enough capacity for right now.
This is precisely how we handle this in sentry-cli, and why we can stick to v1 here:
4 participants
99% of changes are automatic formatting changes. Only relevant change is bumping
@sentry/clifrom1.74.3to1.74.4